Show a notice when a field value was rejected - #21
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
marked this pull request as ready for review
August 2, 2026 18:41
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 5, 2026 23:12
7ab0711 to
0a99efa
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 5, 2026 23:31
0a99efa to
bc63cd6
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 5, 2026 23:44
bc63cd6 to
32fd50b
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 14, 2026 17:03
32fd50b to
334f881
Compare
masnwilliams
changed the title
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 20, 2026 20:06
334f881 to
88003e5
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 20, 2026 20:12
88003e5 to
1ceef72
Compare
masnwilliams
force-pushed
the
hypeship/replace-existing-field-notice
branch
from
August 20, 2026 20:27
1ceef72 to
bd66c28
Compare
akxue
approved these changes
Aug 21, 2026
akxue
left a comment
akxue
left a comment
There was a problem hiding this comment.
reviewed — no blockers found. approving.
questions
packages/managed-auth-react/src/lib/types.ts:77—ManagedAuthFieldis publicly exported and now requiresreason. can you confirm which downstream consumers construct this type and whether the release notes or versioning should call out the migration? this is non-blocking; mason likely has the right context.
tests
packages/managed-auth-react/src/components/UnifiedAuthForm.tsx:303-306— consider adding a component test covering rejection-notice rendering, localization, and the appearance slot.
accessibility
packages/managed-auth-react/src/components/UnifiedAuthForm.tsx:303-306— consider associating the notice with the input viaaria-describedbyand using polite live-region behavior so screen readers announce asynchronous rejection updates.
validation: bun test (20 passed), package build, typecheck, and format check all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
reason: "missing" | "rejected"reason === "rejected"fieldRejectedNoticeandinputRejectedNoticecustomization points@onkernel/sdk@0.93.0This removes the temporary public
replace_existingshape entirely.stack
testing
bun run testbun run typecheckbun run buildbun run format:checkcd packages/managed-auth-react && npm pack --dry-runmanaged-auth-hosted-uibun run test,bun run typecheck,bun run lint,bun run build,bun run format:checkNote
Medium Risk
Touches auth form UX, field protocol types, and canonical-to-UI projection. Risk is moderate: user-facing credential flow, but no auth/security logic or credential handling changes.
Overview
Shows a localized, customizable notice when a canonical field has
reason: "rejected", so users know a saved value was not accepted and need to enter a new one.Canonical
ManagedAuthFieldnow requiresreason: "missing" | "rejected". That reason is projected onto rendered fields. The form only shows the notice for"rejected", wires it intoaria-describedbywithrole="status", and keeps any existing hint. Appearance/localization hooks areinputRejectedNoticeandfieldRejectedNotice.Canonical-to-UI mapping also preserves legacy
placeholder/hintwhile both shapes coexist. Vendored protocol types are compile-checked against@onkernel/sdk@0.93.0.Reviewed by Cursor Bugbot for commit a5c2f00. Bugbot is set up for automated code reviews on this repo. Configure here.